Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standalone Tooltip Icon #4909

Merged
merged 10 commits into from
Jun 5, 2023
Merged

Standalone Tooltip Icon #4909

merged 10 commits into from
Jun 5, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 22, 2023

This PR adds a standalone Tooltip Icon.

Todo:

  • Add unit test / UI test
  • Add documentation
screenrecord-2023-05-22_14.52.40.mp4
import panel as pn
from bokeh.models import Tooltip

pn.extension()

pn.widgets.TooltipIcon(value="Test")

plaintext_tooltip = Tooltip(content="Tooltip", position="right")
pn.widgets.TooltipIcon(value=plaintext_tooltip)

pn.Row(pn.panel("Hello"), pn.widgets.TooltipIcon(value="Test", align='center'))

@codecov
Copy link

codecov bot commented May 22, 2023

Codecov Report

Merging #4909 (a003b63) into main (1980f5a) will decrease coverage by 0.43%.
The diff coverage is 98.27%.

@@            Coverage Diff             @@
##             main    #4909      +/-   ##
==========================================
- Coverage   82.79%   82.37%   -0.43%     
==========================================
  Files         271      272       +1     
  Lines       38607    38656      +49     
==========================================
- Hits        31966    31842     -124     
- Misses       6641     6814     +173     
Flag Coverage Δ
ui-tests 39.72% <77.58%> (-0.96%) ⬇️
unitexamples-tests 72.32% <56.89%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/models/__init__.py 100.00% <ø> (ø)
panel/widgets/__init__.py 100.00% <ø> (ø)
panel/widgets/base.py 90.56% <88.88%> (-0.62%) ⬇️
panel/models/widgets.py 100.00% <100.00%> (ø)
panel/tests/io/test_resources.py 99.00% <100.00%> (ø)
panel/tests/ui/widgets/test_indicators.py 100.00% <100.00%> (ø)
panel/widgets/indicators.py 73.07% <100.00%> (+0.25%) ⬆️

... and 14 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro marked this pull request as draft May 22, 2023 19:17
@philippjfr philippjfr added this to the v1.1.0 milestone May 22, 2023
@hoxbro hoxbro marked this pull request as ready for review June 5, 2023 14:23
@hoxbro hoxbro requested a review from philippjfr June 5, 2023 14:23
@philippjfr philippjfr merged commit cec9547 into main Jun 5, 2023
@philippjfr philippjfr deleted the tooltip_icon branch June 5, 2023 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants