Attempt rendering even if not all dependencies could be loaded #4893
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4893 +/- ##
===========================================
+ Coverage 73.36% 83.41% +10.05%
===========================================
Files 270 270
Lines 38138 38138
===========================================
+ Hits 27981 31814 +3833
+ Misses 10157 6324 -3833
Flags with carried forward coverage won't be shown. Click here to find out more. see 56 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the notebook we always check that all the required dependencies were loaded correctly. This makes sense but if we reach the timeout and Bokeh and Panel are loaded we should just go ahead and try to render anyway since not all output will require all JS dependencies and some output >>> no output.