Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load index template resources from CDN #4891

Merged
merged 3 commits into from
May 19, 2023
Merged

Load index template resources from CDN #4891

merged 3 commits into from
May 19, 2023

Conversation

philippjfr
Copy link
Member

The index template was loading resources that were no longer bundled and also loading them from the /latest directory on the CDN which is note future proof. Here we align the handling with the main fast templates, upgrading to the recent version of fast-components and using our custom color handling implementation.

Fixes #4881

@codecov
Copy link

codecov bot commented May 19, 2023

Codecov Report

Merging #4891 (015e5d0) into main (f623f59) will increase coverage by 0.02%.
The diff coverage is 100.00%.

❗ Current head 015e5d0 differs from pull request most recent head c7d456d. Consider uploading reports for the commit c7d456d to get more accurate results

@@            Coverage Diff             @@
##             main    #4891      +/-   ##
==========================================
+ Coverage   83.37%   83.39%   +0.02%     
==========================================
  Files         270      270              
  Lines       38130    38137       +7     
==========================================
+ Hits        31789    31804      +15     
+ Misses       6341     6333       -8     
Flag Coverage Δ
ui-tests 40.84% <75.00%> (+0.02%) ⬆️
unitexamples-tests 73.36% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/server.py 77.09% <100.00%> (+0.26%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr changed the title Load index template from resources from CDN Load index template resources from CDN May 19, 2023
@philippjfr philippjfr merged commit 1edc2fc into main May 19, 2023
@philippjfr philippjfr deleted the index_resources branch May 19, 2023 11:12
@philippjfr philippjfr added this to the v1.0.2 milestone May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gallery index page loads resources from wrong place
1 participant