Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace user guide links #4875

Merged
merged 1 commit into from
May 18, 2023
Merged

Replace user guide links #4875

merged 1 commit into from
May 18, 2023

Conversation

droumis
Copy link
Member

@droumis droumis commented May 18, 2023

This is in progress, there are many more to fix. :(

@droumis
Copy link
Member Author

droumis commented May 18, 2023

@philippjfr, for updates to accessing/manipulating the url (how_to/state/url), I put the port number after the domain .org. Is that incorrect? Before, the page has it after the file path .html

update: Discussed this with @hoxbro - port number after the domain .org is always correct; so the page seems just to have had a typo.

@codecov
Copy link

codecov bot commented May 18, 2023

Codecov Report

Merging #4875 (4465756) into main (eee3879) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #4875   +/-   ##
=======================================
  Coverage   83.39%   83.39%           
=======================================
  Files         270      270           
  Lines       38122    38122           
=======================================
  Hits        31791    31791           
  Misses       6331     6331           
Flag Coverage Δ
ui-tests 40.87% <0.00%> (ø)
unitexamples-tests 73.34% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/depends.py 74.73% <ø> (ø)
panel/layout/spacer.py 79.31% <ø> (ø)
panel/tests/models/test_location.py 100.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Note I made a lot of fixes here: #4872

@philippjfr philippjfr marked this pull request as ready for review May 18, 2023 11:22
Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philippjfr philippjfr merged commit 1e83b1d into main May 18, 2023
@philippjfr philippjfr deleted the replace-UG-links branch May 18, 2023 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants