-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Various theming fixes #4793
Various theming fixes #4793
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4793 +/- ##
===========================================
+ Coverage 73.33% 83.40% +10.07%
===========================================
Files 268 268
Lines 37883 37883
===========================================
+ Hits 27782 31597 +3815
+ Misses 10101 6286 -3815
Flags with carried forward coverage won't be shown. Click here to find out more. see 55 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
For the For me the original 0.14.4 design is most valuable. I don't think the bootstrap colors goes well with the fast design. 0.14.4. DesignDefaultPrimaryThis style is used to highlight the primary button to press in your app. It guides the user. Its really important to have. SuccessI think this style works particularly well when applied to the Warning(This has nothing to do with a warning. But it exposes a style of button exposed by Fast). Danger(This has nothing to do with a warning. But it exposes the link button exposed by Fast). Light(same as default) |
That overloading of the names is pretty weird. I think we should add another parameter that allows switching between outline, accent and stealth styling. |
It does indeed. |
Various small tweaks to Bootstrap, Material and Fast designs and themes.