Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various theming fixes #4793

Merged
merged 1 commit into from
May 6, 2023
Merged

Various theming fixes #4793

merged 1 commit into from
May 6, 2023

Conversation

philippjfr
Copy link
Member

Various small tweaks to Bootstrap, Material and Fast designs and themes.

@codecov
Copy link

codecov bot commented May 6, 2023

Codecov Report

Merging #4793 (3be416f) into main (0a0f929) will increase coverage by 10.07%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #4793       +/-   ##
===========================================
+ Coverage   73.33%   83.40%   +10.07%     
===========================================
  Files         268      268               
  Lines       37883    37883               
===========================================
+ Hits        27782    31597     +3815     
+ Misses      10101     6286     -3815     
Flag Coverage Δ
ui-tests 40.71% <ø> (?)
unitexamples-tests 73.34% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 55 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 90d3865 into main May 6, 2023
@philippjfr philippjfr deleted the theme_fixes branch May 6, 2023 11:25
@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented May 7, 2023

For the Fast buttons you will have to choose if you select to 0.14.4 design which exposes the different types of Fast styles or a Bootstrap like style where buttons in different colors are exposed. I've seen users ask for both.

For me the original 0.14.4 design is most valuable. I don't think the bootstrap colors goes well with the fast design.

0.14.4. Design

Default

image

Primary

image

This style is used to highlight the primary button to press in your app. It guides the user. Its really important to have.

Success

image

I think this style works particularly well when applied to the RadioButtonGroup. So it would be a big loss for me if not available.

Warning

image

(This has nothing to do with a warning. But it exposes a style of button exposed by Fast).

Danger

image

(This has nothing to do with a warning. But it exposes the link button exposed by Fast).

Light

image

(same as default)

@philippjfr
Copy link
Member Author

That overloading of the names is pretty weird. I think we should add another parameter that allows switching between outline, accent and stealth styling.

@philippjfr
Copy link
Member Author

For now I've got solid and outline:

button

@philippjfr
Copy link
Member Author

And for the RadioButtonGroup:

Screen Shot 2023-05-07 at 12 09 49

@MarcSkovMadsen
Copy link
Collaborator

MarcSkovMadsen commented May 7, 2023

For now I've got solid and outline:

button

If "primary" is using the accent color, then that looks great to me. If it does not, an easy way to apply the accent color would be appreciated.

@philippjfr
Copy link
Member Author

It does indeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants