Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default for description to None #4621

Merged
merged 1 commit into from
Apr 11, 2023
Merged

Set default for description to None #4621

merged 1 commit into from
Apr 11, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Apr 11, 2023

Fixes #4617

image

@philippjfr
Copy link
Member

Great, thanks @hoxbro. Could you maybe create an issue with a table that summarizes which widget do and do not support tooltips and link it with the equivalent issue for widget titles (which I am having trouble finding right now)?

@codecov
Copy link

codecov bot commented Apr 11, 2023

Codecov Report

Merging #4621 (5d85e84) into main (e179a2d) will decrease coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4621      +/-   ##
==========================================
- Coverage   73.32%   73.31%   -0.02%     
==========================================
  Files         260      260              
  Lines       37127    37127              
==========================================
- Hits        27224    27219       -5     
- Misses       9903     9908       +5     
Flag Coverage Δ
unitexamples-tests 73.31% <100.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/input.py 95.16% <100.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hoxbro, looks good.

@philippjfr philippjfr merged commit fa1185b into main Apr 11, 2023
@philippjfr philippjfr deleted the fix_description branch April 11, 2023 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tooltip symbol shown when no description/ tooltip provided
2 participants