Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow passing methods with dependencies by reference #4603

Merged
merged 2 commits into from
Apr 6, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 5, 2023

When I implemented passing parameters and functions by reference to components constructors I had not considered methods on Parameterized objects.

  • Add tests

@codecov
Copy link

codecov bot commented Apr 5, 2023

Codecov Report

Merging #4603 (19b2328) into main (872c136) will increase coverage by 0.01%.
The diff coverage is 94.44%.

@@            Coverage Diff             @@
##             main    #4603      +/-   ##
==========================================
+ Coverage   83.73%   83.74%   +0.01%     
==========================================
  Files         260      260              
  Lines       37036    37103      +67     
==========================================
+ Hits        31012    31073      +61     
- Misses       6024     6030       +6     
Flag Coverage Δ
ui-tests 39.57% <11.11%> (-0.06%) ⬇️
unitexamples-tests 73.87% <94.44%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/test_util.py 95.16% <90.00%> (-4.84%) ⬇️
panel/util/__init__.py 87.59% <95.23%> (+0.65%) ⬆️
panel/reactive.py 80.60% <100.00%> (ø)
panel/tests/test_reactive.py 99.19% <100.00%> (+0.03%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit bc1d2f3 into main Apr 6, 2023
@philippjfr philippjfr deleted the param_method_reactive branch April 6, 2023 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant