Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Define custom parameters and make margin consistent #4528

Merged
merged 5 commits into from
Mar 13, 2023
Merged

Conversation

philippjfr
Copy link
Member

  • Defines custom parameter types for Align, Aspect and Margin.
  • Consistently set margins on components

@codecov
Copy link

codecov bot commented Mar 13, 2023

Codecov Report

Merging #4528 (0caf515) into main (31b5b0b) will decrease coverage by 9.86%.
The diff coverage is 81.13%.

@@            Coverage Diff             @@
##             main    #4528      +/-   ##
==========================================
- Coverage   83.40%   73.54%   -9.86%     
==========================================
  Files         246      247       +1     
  Lines       36270    36309      +39     
==========================================
- Hits        30251    26705    -3546     
- Misses       6019     9604    +3585     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 73.54% <81.13%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/layout/base.py 92.66% <ø> (-0.06%) ⬇️
panel/layout/card.py 93.65% <ø> (-0.10%) ⬇️
panel/layout/flex.py 95.65% <ø> (-0.19%) ⬇️
panel/layout/gridstack.py 52.23% <ø> (-33.06%) ⬇️
panel/layout/spacer.py 76.92% <ø> (-0.86%) ⬇️
panel/pane/markup.py 93.78% <ø> (-0.04%) ⬇️
panel/pane/vega.py 82.16% <ø> (-0.10%) ⬇️
panel/template/base.py 77.69% <ø> (-0.05%) ⬇️
panel/widgets/file_selector.py 84.70% <ø> (-0.09%) ⬇️
panel/_param.py 78.72% <78.72%> (ø)
... and 2 more

... and 42 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit fc23efe into main Mar 13, 2023
@philippjfr philippjfr deleted the custom_params branch March 13, 2023 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant