Tabulator: keywords and like filters aren't regex #4423
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
approved these changes
Feb 8, 2023
Codecov Report
@@ Coverage Diff @@
## main #4423 +/- ##
==========================================
- Coverage 81.80% 81.60% -0.20%
==========================================
Files 238 238
Lines 34872 34872
==========================================
- Hits 28526 28458 -68
- Misses 6346 6414 +68
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Oops, meant to merge another PR but was on my phone. Just add the test sometime. |
maximlt
added a commit
that referenced
this pull request
Feb 22, 2023
maximlt
added a commit
that referenced
this pull request
Feb 22, 2023
Merged
maximlt
added a commit
that referenced
this pull request
Mar 3, 2023
* keywords and like filters aren't regex (#4423) * add examples folder dynamically added to the distrib (#4484) * Small bug fixes (#4481) * use the right name for the method that gets the image data * Bump cryptography in /examples/apps/django_multi_apps (#4418) * Use latest react-grid from CDN (#4461) * Fix url * Fix React template * prepare release notes * Modify sys.path when running inside Jupyter Kernel (#4489) * Add support for altair and vega-lite v5 (#4488) * Do not re-create Vega.selections object unless selections changed (#4497) * Bump panel.js version to 0.14.4-rc.2 --------- Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tabulator JSdefines the like and keywords filters as follows:These filters were implemented with Pandas'
.str.containsmethod that by default expects the pattern to be a regular expression. This PR sets the Pandasregexparameter toFalseto avoid that. Additionally it sets thecaseparameter toFalsetoo as as described inTabulator JS' docs these two filters are case insensitive. There was no issue with that as all the strings compared were lower-cased (I believe.casefold()is a better fit to compare strings ignoring their case), it's just a little cleaner.