Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom components User Guide reorg #4412

Merged
merged 5 commits into from
Feb 8, 2023
Merged

Conversation

droumis
Copy link
Member

@droumis droumis commented Feb 6, 2023

Migrates the Custom components User Guide into:

  1. How To about Viewer components (combining existing components)
  2. How To about ReactiveHTML (building from scratch recipes)
  3. Background about ReactiveHTML (building from scratch, with all the discussion and details)

image

@droumis droumis requested a review from philippjfr February 6, 2023 17:44
@codecov
Copy link

codecov bot commented Feb 6, 2023

Codecov Report

Merging #4412 (be6aeef) into main (06ae142) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4412      +/-   ##
==========================================
- Coverage   82.78%   82.78%   -0.01%     
==========================================
  Files         240      240              
  Lines       34822    34822              
==========================================
- Hits        28829    28826       -3     
- Misses       5993     5996       +3     
Flag Coverage Δ
ui-tests 38.25% <ø> (+<0.01%) ⬆️
unitexamples-tests 73.79% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/util.py 89.32% <0.00%> (-1.95%) ⬇️
panel/io/state.py 70.29% <0.00%> (-0.35%) ⬇️
panel/util/__init__.py 87.11% <0.00%> (+0.44%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great but I'd probably suggest we move the two new How To guides into a section about extending Panel.

@philippjfr philippjfr merged commit 6f3f1bd into main Feb 8, 2023
@philippjfr philippjfr deleted the custom-components-ug-reorg branch February 8, 2023 11:13
@philippjfr
Copy link
Member

Thanks @droumis!

@droumis droumis mentioned this pull request Feb 13, 2023
This was referenced Feb 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants