Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure notifications are enabled even if hv.extension has been loaded #4330

Merged
merged 1 commit into from
Jan 26, 2023
Merged

Ensure notifications are enabled even if hv.extension has been loaded #4330

merged 1 commit into from
Jan 26, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4229

@philippjfr philippjfr requested a review from hoxbro January 26, 2023 16:31
@codecov
Copy link

codecov bot commented Jan 26, 2023 •
edited
Loading

Codecov Report

Merging #4330 (9569040) into main (47f231b) will not change coverage.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##             main    #4330   +/-   ##
=======================================
  Coverage   82.74%   82.74%           
=======================================
  Files         240      240           
  Lines       34558    34558           
=======================================
  Hits        28596    28596           
  Misses       5962     5962
Flag Coverage Δ
ui-tests 38.30% <0.00%> (+0.01%) ⬆️
unitexamples-tests 73.78% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/config.py 59.59% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 472f633 into main Jan 26, 2023
@philippjfr philippjfr deleted the notification_loaded branch January 26, 2023 18:31
philippjfr added a commit that referenced this pull request Jan 26, 2023
@philippjfr
Ensure notifications are enabled even if hv.extension has been loaded (…
4fb8423 
…#4330)
@philippjfr philippjfr mentioned this pull request Jan 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hoxbro hoxbro Awaiting requested review from hoxbro

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Notifications does not work in notebook if hv.extension has been run before
1 participant
@philippjfr