Provide ability to set design system independently from template #4326
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
07a15ff to
3b080c5
Compare
92c72b3 to
7d5b037
Compare
Codecov Report
@@ Coverage Diff @@
## main #4326 +/- ##
==========================================
- Coverage 81.80% 81.77% -0.03%
==========================================
Files 238 243 +5
Lines 34872 35206 +334
==========================================
+ Hits 28526 28791 +265
- Misses 6346 6415 +69
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
f9a5320 to
d7df015
Compare
|
pre-commit.ci autofix |
Closed
|
Would ot be possible One day to set the design system in a separate package? Say I want to use a custom design system. |
Definitely, if you provide URLs you should already be able to achieve this. Still have to add support for serving them locally though. |
cf09bf1 to
1b1ab09
Compare
This was referenced Feb 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the concept of a
Designwhich can be configured directly on individual components, globally on thepn.configand via a template (i.e. the MaterialTemplate uses theMaterialDesignobject).This allows applying design system to our components independently of templates, e.g. also in notebooks. Here is an overview of the design of different component types in a notebook. This is very much a WIP and I'm not aiming to get everything looking perfectly in this PR. I'm mostly trying to ensure that the different design systems we offer render at all and further tweak specific CSS in subsequent PRs.
Below are the three design systems displayed in JupyterLab (using the default theme and adapting to the JupyterLab theme). Note that any properties set in Python, e.g. the Bokeh theme, do not automatically adapt to the JupyterLab dark theme.
Bootstrap
Material
Fast