Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure updates to Tabulator formatter or editor updates model #4296

Merged
merged 2 commits into from
Jan 17, 2023

Conversation

philippjfr
Copy link
Member

When providing CellEditor and CellFormatter objects to Tabulator updating the properties on these objects would not have any effect.

@philippjfr philippjfr added type: bug component: tabulator Related to the Tabulator widget labels Jan 17, 2023
@codecov
Copy link

codecov bot commented Jan 17, 2023

Codecov Report

Merging #4296 (f8e6d19) into main (9388d39) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #4296      +/-   ##
==========================================
+ Coverage   82.70%   82.74%   +0.03%     
==========================================
  Files         239      239              
  Lines       34464    34510      +46     
==========================================
+ Hits        28505    28555      +50     
+ Misses       5959     5955       -4     
Flag Coverage Δ
ui-tests 38.10% <53.19%> (+0.02%) ⬆️
unitexamples-tests 73.83% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/widgets/test_tables.py 99.67% <100.00%> (+<0.01%) ⬆️
panel/widgets/tables.py 88.78% <100.00%> (+0.50%) ⬆️
panel/util/__init__.py 86.66% <0.00%> (-0.45%) ⬇️
panel/tests/util.py 91.26% <0.00%> (+1.94%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 3fe6ae3 into main Jan 17, 2023
@philippjfr philippjfr deleted the table_model_change branch January 17, 2023 15:14
philippjfr added a commit that referenced this pull request Jan 17, 2023
* Ensure updates to Tabulator formatter or editor updates model

* Optimize column definition update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: tabulator Related to the Tabulator widget
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant