-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrate Customization User Guide content #4290
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4290 +/- ##
==========================================
+ Coverage 82.67% 82.69% +0.01%
==========================================
Files 239 239
Lines 34393 34464 +71
==========================================
+ Hits 28436 28499 +63
- Misses 5957 5965 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, thank you! I'll look at the issues you raised separately. One last thing, could you please remove the Customization.ipynb now that you've migrated the contents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I removed it. Thanks again!
I moved most of the content into new How-to pages under
Create Components > Style Components
andCreate Components > Arrange and Size Components
. There wasn't much in terms of Background or Core Concept material. There may be some material that could also go into a reference, but we first need to align on the next step for reference material.In both
apply_css.md
andload_icon.md
, I added an admonition that says that the embedded code may not render on the page due to incompatibility with pyodide. I guess it could be some interaction with setting the panel configuration. This is just what I observed when built locally. Is this a bug or am I doing something incorrectly?other previews:
