Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IPython display compatibility in pyodide builds #4270

Merged
merged 1 commit into from
Jan 11, 2023
Merged

Conversation

philippjfr
Copy link
Member

Compatibility layer for IPython display functionality. Only handles a single display output per "cell" and only if the cell does not otherwise return anything, so only a partial fix but should be sufficient for demonstrating display in documentation.

Fixes #4266

@codecov
Copy link

codecov bot commented Jan 11, 2023

Codecov Report

Merging #4270 (56a8994) into main (5a39b76) will decrease coverage by 0.00%.
The diff coverage is 71.42%.

@@            Coverage Diff             @@
##             main    #4270      +/-   ##
==========================================
- Coverage   82.71%   82.71%   -0.01%     
==========================================
  Files         237      237              
  Lines       34285    34292       +7     
==========================================
+ Hits        28359    28363       +4     
- Misses       5926     5929       +3     
Flag Coverage Δ
ui-tests 37.97% <28.57%> (-0.01%) ⬇️
unitexamples-tests 73.87% <71.42%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/mime_render.py 83.11% <71.42%> (-0.56%) ⬇️
panel/util/__init__.py 86.66% <0.00%> (-0.45%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 5a69995 into main Jan 11, 2023
@philippjfr philippjfr deleted the mime_render_display branch January 11, 2023 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPython's built in 'display' doesn't work with pyodide directive
1 participant