-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganize components user guide into other doc sections #4267
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4267 +/- ##
===========================================
- Coverage 82.71% 70.31% -12.41%
===========================================
Files 237 237
Lines 34283 34285 +2
===========================================
- Hits 28358 24107 -4251
- Misses 5925 10178 +4253
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Looking great, can you:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the fixes! Looking good.
Did you want to remove Remove doc/user_guide/Components.md? |
Yep! just removed it. Should be ready to merge now if those were all the comments |
Perfect, will just go ahead and merge without waiting on tests since those changes shouldn't affect anything. |
Addresses a small part of #3869 (also see #4251) by reorganizing the Components User Guide, and in the process initializes the Background section.
How To > Components: