Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add contributing guide #4262

Merged
merged 8 commits into from
Jan 16, 2023
Merged

Add contributing guide #4262

merged 8 commits into from
Jan 16, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

Addresses part of #4260 by adding a CONTRIBUTING.md guide.

@philippjfr . You could consider giving this a quick review and merge for now. Then we can do a second iteration later where we dig deeper into improving the CONTRIBUTING docs in general?

@MarcSkovMadsen MarcSkovMadsen added this to the next milestone Jan 8, 2023
@codecov
Copy link

codecov bot commented Jan 8, 2023

Codecov Report

Merging #4262 (c55f777) into main (3086230) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #4262      +/-   ##
==========================================
- Coverage   82.67%   82.67%   -0.01%     
==========================================
  Files         239      239              
  Lines       34393    34393              
==========================================
- Hits        28436    28433       -3     
- Misses       5957     5960       +3     
Flag Coverage Δ
ui-tests 37.99% <ø> (-0.01%) ⬇️
unitexamples-tests 73.81% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/tests/ui/widgets/test_tabulator.py 98.81% <0.00%> (-0.17%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr
Copy link
Member

Happy with this as a first cut. We'll probably make adjustments as we overhaul the developer documentation.

@philippjfr philippjfr merged commit fae62f9 into main Jan 16, 2023
@philippjfr philippjfr deleted the feature/contributing_md branch January 16, 2023 11:22
philippjfr pushed a commit that referenced this pull request Jan 16, 2023
@philippjfr philippjfr modified the milestones: next, v0.14.3 Feb 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants