Deprecate IDOM #4254
Closed
Deprecate IDOM #4254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4254 +/- ##
==========================================
- Coverage 82.71% 74.06% -8.66%
==========================================
Files 237 235 -2
Lines 34276 34129 -147
==========================================
- Hits 28351 25276 -3075
- Misses 5925 8853 +2928
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
hoxbro
reviewed
Jan 6, 2023
| class IDOM: | ||
| def __init__(self, *args, **kwargs): | ||
| raise RuntimeError( | ||
| "The IDOM pane was deprecated from Panel in version 1.0 " |
There was a problem hiding this comment.
Suggested change
| "The IDOM pane was deprecated from Panel in version 1.0 " | |
| "The IDOM pane was removed from Panel in version 1.0 " |
| @@ -146,7 +146,7 @@ def run(self): | |||
| 'markdown-it-py', | |||
| 'ipyvuetify', | |||
| 'reacton', | |||
| # Added lxml temporarily as installing pyechars or idom on Python 3.11 | |||
| # Added lxml temporarily as installing pyecharts or idom on Python 3.11 | |||
There was a problem hiding this comment.
Suggested change
| # Added lxml temporarily as installing pyecharts or idom on Python 3.11 | |
| # Added lxml temporarily as installing pyecharts on Python 3.11 |
|
Shouldn't there first be a release deprecating it and then removing it? That might send the signal that Panel can remove things any time. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've decided to deprecate the IDOM pane. IDOM is a cool project but after I initially implemented it on top of preact the architecture changed significantly which effectively meant that we could only support older versions. I think supporting it would still be nice but I would probably want to move it into a separate
panel-idompackage.For now I've put a
IDOMstub object intopanel.panethat simply errors when you instantiate it. This is because we did not really telegraph the deprecation.