Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow invoking convert from pyodide #4135

Merged
merged 2 commits into from
Nov 17, 2022
Merged

Allow invoking convert from pyodide #4135

merged 2 commits into from
Nov 17, 2022

Conversation

philippjfr
Copy link
Member

Fixes #4067

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #4135 (e8c513d) into master (ebd7fc5) will increase coverage by 0.02%.
The diff coverage is 90.00%.

@@            Coverage Diff             @@
##           master    #4135      +/-   ##
==========================================
+ Coverage   83.56%   83.58%   +0.02%     
==========================================
  Files         224      224              
  Lines       33381    33391      +10     
==========================================
+ Hits        27895    27911      +16     
+ Misses       5486     5480       -6     
Flag Coverage Δ
ui-tests 37.64% <90.00%> (+0.01%) ⬆️
unitexamples-tests 74.56% <13.33%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/convert.py 72.13% <90.00%> (-0.10%) ⬇️
panel/pane/base.py 88.75% <0.00%> (+0.83%) ⬆️
panel/tests/util.py 89.32% <0.00%> (+0.97%) ⬆️
panel/tests/pane/test_base.py 96.00% <0.00%> (+12.00%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 6bf5267 into master Nov 17, 2022
@philippjfr philippjfr deleted the convert_in_pyodide branch November 17, 2022 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make it possible to convert_app in pyodide
1 participant