Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make periodic callback counter a parameter #4134

Merged
merged 1 commit into from
Mar 14, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #4125

@codecov
Copy link

codecov bot commented Nov 17, 2022

Codecov Report

Merging #4134 (9a3cb6e) into master (ebd7fc5) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4134      +/-   ##
==========================================
- Coverage   83.56%   83.48%   -0.08%     
==========================================
  Files         224      224              
  Lines       33381    33367      -14     
==========================================
- Hits        27895    27857      -38     
- Misses       5486     5510      +24     
Flag Coverage Δ
ui-tests 37.55% <100.00%> (-0.07%) ⬇️
unitexamples-tests 74.54% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/callbacks.py 79.85% <100.00%> (+1.01%) ⬆️
panel/tests/ui/io/test_jupyter_server_extension.py 50.00% <0.00%> (-50.00%) ⬇️
panel/tests/ui/io/test_jupyterlite.py 89.18% <0.00%> (-8.11%) ⬇️
panel/tests/pane/test_vtk.py 87.82% <0.00%> (-5.17%) ⬇️
panel/tests/ui/io/test_convert.py 92.92% <0.00%> (-2.66%) ⬇️
panel/tests/command/test_serve.py 83.95% <0.00%> (-1.42%) ⬇️
panel/tests/util.py 87.25% <0.00%> (-1.10%) ⬇️
panel/tests/conftest.py 87.50% <0.00%> (-0.92%) ⬇️
panel/pane/vtk/synchronizable_serializer.py 77.35% <0.00%> (-0.32%) ⬇️
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 3c24321 into main Mar 14, 2023
@philippjfr philippjfr deleted the periodic_counter branch March 14, 2023 13:11
@philippjfr philippjfr added this to the v1.0.0 milestone Mar 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable users to easily create apps that depends or binds to the PeriodicCallback
1 participant