-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish CDN migration #3870
Finish CDN migration #3870
Conversation
fea2484
to
8cecad4
Compare
Codecov Report
@@ Coverage Diff @@
## master #3870 +/- ##
===========================================
- Coverage 75.09% 34.67% -40.43%
===========================================
Files 224 224
Lines 32816 32812 -4
===========================================
- Hits 24642 11376 -13266
- Misses 8174 21436 +13262
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
After this PR Lumen Builder looks like this: 2022-09-26 11:24:40,970 Starting Bokeh server version 2.4.3 (running on Tornado 6.2)
2022-09-26 11:24:40,970 User authentication hooks NOT provided (default user enabled)
2022-09-26 11:24:40,972 Bokeh app running at: http://localhost:5006/ui
2022-09-26 11:24:40,972 Starting Bokeh server with process id: 69777
2022-09-26 11:24:42,993 W-1002 (EMPTY_LAYOUT): Layout has no children: Column(id='1015', ...)
2022-09-26 11:24:43,101 404 GET /static/extensions/panel/bundled/js/@microsoft/fast-colors@5.3.1/dist/index.js (127.0.0.1) 0.61ms
2022-09-26 11:24:43,102 404 GET /static/extensions/panel/bundled/js/@microsoft/fast-components@1.21.8/dist/fast-components.js (127.0.0.1) 0.66ms
2022-09-26 11:24:43,330 WebSocket connection opened
2022-09-26 11:24:43,331 ServerConnection created |
Are you on Panel master? I cannot reproduce. |
Yes. Both on panel and lumen. |
You'll have to fetch the latest resources by rerunning an editable install on Panel. |
Alternatively you can also just run |
It works now. I needed to run |
Probably due to latest pip nonsense. Setting this probably would have done it:
|
Just found that https://github.com/holoviz/panel/blob/bdf2742679fb16861b8432872aadb0ed3baddda7/panel/_templates/index.html still using the CDN from https://cdn.holoviz.org/panel/latest/dist/bundled/js/, instead of https://cdn.jsdelivr.net/npm. |
cdn.holoviz.org is what it should be using. |
Neither unpkg nor jsdelivr are recommended for production usage so we decided to maintain our own CDN. |
Use
config.npm_cdn
for template resources.