Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure pn.state.execute dispatches immediately if possible #3859

Merged
merged 2 commits into from
Sep 18, 2022

Conversation

philippjfr
Copy link
Member

The logic was wrong and pn.state.execute was scheduling stuff on the event loop when we knew the document to be unblocked.

Fixes #3855

@codecov
Copy link

codecov bot commented Sep 18, 2022

Codecov Report

Merging #3859 (3eda3aa) into master (1a2be00) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master    #3859      +/-   ##
==========================================
- Coverage   82.94%   82.93%   -0.01%     
==========================================
  Files         224      224              
  Lines       32763    32763              
==========================================
- Hits        27174    27172       -2     
- Misses       5589     5591       +2     
Flag Coverage Δ
ui-tests 34.40% <0.00%> (+<0.01%) ⬆️
unitexamples-tests 75.17% <75.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/widgets/tables.py 88.31% <66.66%> (ø)
panel/io/state.py 69.35% <100.00%> (ø)
panel/util.py 87.08% <0.00%> (-0.37%) ⬇️
panel/tests/ui/widgets/test_tabulator.py 98.77% <0.00%> (-0.17%) ⬇️
panel/io/server.py 74.85% <0.00%> (+0.19%) ⬆️
panel/tests/util.py 88.34% <0.00%> (+0.97%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 4bd90a7 into master Sep 18, 2022
@philippjfr philippjfr deleted the fix_execute_condition branch September 18, 2022 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Notifications not displayed immediately in some callbacks
1 participant