Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure location.unsync unsets query params #3806

Merged
merged 1 commit into from
Sep 5, 2022
Merged

Conversation

philippjfr
Copy link
Member

Fixes #3795

@codecov
Copy link

codecov bot commented Sep 5, 2022

Codecov Report

Merging #3806 (4d66196) into master (5f330f2) will increase coverage by 0.00%.
The diff coverage is 95.45%.

@@           Coverage Diff           @@
##           master    #3806   +/-   ##
=======================================
  Coverage   82.97%   82.98%           
=======================================
  Files         221      221           
  Lines       32205    32206    +1     
=======================================
+ Hits        26723    26726    +3     
+ Misses       5482     5480    -2     
Flag Coverage Δ
ui-tests 34.14% <0.00%> (-0.03%) ⬇️
unitexamples-tests 75.44% <95.45%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/io/location.py 82.87% <91.66%> (-0.11%) ⬇️
panel/tests/io/test_location.py 100.00% <100.00%> (ø)
panel/io/reload.py 69.56% <0.00%> (-2.18%) ⬇️
panel/tests/command/test_serve.py 83.54% <0.00%> (-1.46%) ⬇️
panel/tests/util.py 86.00% <0.00%> (-1.13%) ⬇️
panel/util.py 87.16% <0.00%> (-0.38%) ⬇️
panel/io/state.py 70.27% <0.00%> (-0.22%) ⬇️
panel/io/jupyter_server_extension.py 0.00% <0.00%> (ø)
panel/tests/ui/widgets/test_tabulator.py 98.97% <0.00%> (+0.11%) ⬆️
panel/pane/idom.py 28.36% <0.00%> (+0.19%) ⬆️
... and 2 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit c2aeb39 into master Sep 5, 2022
@philippjfr philippjfr deleted the location_unsync branch September 5, 2022 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.state.location.unsync does not update URL
1 participant