-
-
Notifications
You must be signed in to change notification settings - Fork 531
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execute
method to run callbacks and add support to asynchronous on_edit
/on_click
tabulator callbacks
#3550
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
reviewed
May 23, 2022
Codecov Report
@@ Coverage Diff @@
## master #3550 +/- ##
==========================================
+ Coverage 82.76% 82.79% +0.02%
==========================================
Files 199 199
Lines 27435 27470 +35
==========================================
+ Hits 22707 22743 +36
+ Misses 4728 4727 -1
Continue to review full report at Codecov.
|
philippjfr
reviewed
May 23, 2022
on_edit
and on_click
to execute async callbacksexecute
method to run and add support to asynchronous on_edit
/on_click
tabulator callbacks
execute
method to run and add support to asynchronous on_edit
/on_click
tabulator callbacksexecute
method to run callbacks and add support to asynchronous on_edit
/on_click
tabulator callbacks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is achieved through the addition of the
run_callback
method on the states that delegates to the callback call to the right context.Should there me more usage of
run_callback
throughout the code base? e.g. should theon_click
button events make use of it?