Auto-pagination allowed to be set to remote and to switch #3355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3355 +/- ##
=======================================
Coverage 83.27% 83.27%
=======================================
Files 196 196
Lines 26607 26608 +1
=======================================
+ Hits 22156 22157 +1
Misses 4451 4451
Continue to review full report at Codecov.
|
|
Thanks for catching that! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up on #3306 which always set pagination to
localif the number of rows in the df was greater than 200. Another change made in this PR is to avoid triggering the_set_explicict_paginationcallback from_apply_max_size, allowingpaginationto automatically switch from 'local' to 'remote' or inversely when the df size changes.