Redesign Tabulator styles handling #3175
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we were resetting the
styles
property on the model and keeping a local copy on the view. The problem with this is that the same model can be rendered again at a later stage and if when it was deleted thestyles
had been reset then it would render without the styles the second time. Therefore we take the simpler approach of including a random id in the styles so that even when the style hasn't changed it will still trigger updates.