Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Viewer now updates when using depends on __panel__ #3159

Merged
merged 1 commit into from
Feb 3, 2022
Merged

Viewer now updates when using depends on __panel__ #3159

merged 1 commit into from
Feb 3, 2022

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jan 30, 2022

Fixes #3136

I hope this was what was meant with using ParamMethod.

@hoxbro hoxbro changed the title Viewer now better at working with depends functions Viewer now updates when using depends on __panel__ Jan 30, 2022
@codecov
Copy link

codecov bot commented Jan 30, 2022

Codecov Report

Merging #3159 (1325cc4) into master (5bd9fc8) will decrease coverage by 0.03%.
The diff coverage is 33.33%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3159      +/-   ##
==========================================
- Coverage   82.99%   82.96%   -0.04%     
==========================================
  Files         192      192              
  Lines       25482    25504      +22     
==========================================
+ Hits        21150    21160      +10     
- Misses       4332     4344      +12     
Impacted Files Coverage Δ
panel/viewable.py 69.36% <33.33%> (-1.09%) ⬇️
panel/pane/markup.py 96.17% <0.00%> (-1.05%) ⬇️
panel/widgets/input.py 96.29% <0.00%> (-0.46%) ⬇️
panel/widgets/tables.py 84.76% <0.00%> (-0.22%) ⬇️
panel/io/save.py 62.60% <0.00%> (+0.32%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5bd9fc8...1325cc4. Read the comment docs.

@philippjfr philippjfr merged commit 3768a17 into holoviz:master Feb 3, 2022
@hoxbro hoxbro deleted the enh_viewable branch February 3, 2022 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update Viewer to work with depends on __panel__
2 participants