Fixing enabling and disabling FileDownload #1834
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1510 and #1820
There seems to have been two problems: The first problem is that Button do not have a
value
property and therefore give the"Uncaught TypeError: t is undefined"
as mentioned in #1510 and here.The second problem was that the change in
disabled
was not connected to the anchor element.This is my first time trying to write code in TypeScript, so I think it would be very good if someone with more experience in TypeScript can take a look at it and test that I haven't done something wrong or if there is something which can be done better.
An example of the fix in action can be seen below: