[VTK] Add colorbar on vtk renderer #1270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
xavArtley
commented
Apr 14, 2020
Codecov Report
@@ Coverage Diff @@
## master #1270 +/- ##
==========================================
+ Coverage 87.53% 87.55% +0.02%
==========================================
Files 117 117
Lines 12952 12963 +11
==========================================
+ Hits 11337 11350 +13
+ Misses 1615 1613 -2
Continue to review full report at Codecov.
|
philippjfr
reviewed
Apr 15, 2020
philippjfr
reviewed
Apr 15, 2020
philippjfr
reviewed
Apr 15, 2020
philippjfr
reviewed
Apr 15, 2020
panel/pane/vtk/vtk.py
Outdated
| @@ -331,6 +331,10 @@ class VTK(PaneBase): | |||
| Define if the object serialization occurs at panel instantiation | |||
| or when the panel is displayed.""") | |||
|
|
|||
| color_mappers = param.List(doc=""" | |||
There was a problem hiding this comment.
Can we keep the parameters sorted alphabetically?
|
A few nitpicky comments otherwise looks good. |
Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
Co-Authored-By: Philipp Rudiger <prudiger@anaconda.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.