-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gpu marker and test both Classic/dask-expr Dask DataFrames #1341
Conversation
return request.param() | ||
|
||
|
||
@pytest.fixture(params=[1, 2, 4]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see no reason why to test for 1 to 4, so I removed 3.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1341 +/- ##
==========================================
- Coverage 90.38% 90.31% -0.08%
==========================================
Files 91 92 +1
Lines 18764 18579 -185
==========================================
- Hits 16960 16779 -181
+ Misses 1804 1800 -4 ☔ View full report in Codecov by Sentry. |
By having it as markers it should be easy to test
--gpu
tests separately and not wait for the whole suite to pass. Running the non-GPU test continuously runs on the CI.The classic / dask-expr was mostly something I wanted to test out if I could get to work, and was "easy" to do when the rest of the test infrastructure was updated.