Parallelize the test suite and fix a test polluted bug #1338
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1338 +/- ##
==========================================
+ Coverage 85.57% 85.63% +0.06%
==========================================
Files 51 53 +2
Lines 11296 11316 +20
==========================================
+ Hits 9667 9691 +24
+ Misses 1629 1625 -4 |
|
| xbinsize = abs(float(xr_ds[x_name][1] - xr_ds[x_name][0])) | ||
| ybinsize = abs(float(xr_ds[y_name][1] - xr_ds[y_name][0])) |
There was a problem hiding this comment.
These were causing the failing test, as they both were -1. I can't see any reason why these should not be positive.
For reference: pytest 'datashader/tests/test_quadmesh.py::test_raster_quadmesh_autorange_reversed[dask.array]'
| @@ -254,7 +254,7 @@ def to_numpy_dtype(self): | |||
| return np.dtype('datetime64[us]') | |||
|
|
|||
|
|
|||
| _units = set(['ns', 'us', 'ms', 's', 'm', 'h', 'D', 'W', 'M', 'Y']) | |||
| _units = ('ns', 'us', 'ms', 's', 'm', 'h', 'D', 'W', 'M', 'Y') | |||
There was a problem hiding this comment.
pytest-xdist can't handle sets as the order are not consistent, see here.
| @@ -0,0 +1,34 @@ | |||
| CUSTOM_MARKS = ("benchmark",) | |||
There was a problem hiding this comment.
Copied from HoloViews. Basically, it makes it so benchmark only runs when you pass in --benchmark. Benchmark does not work with pytest-xdist (it emits a warning if both are enabled at the same time, which is why I disable it with --benchmark-skip.
At some point, I would also like to add a GPU marker, so it is possible to run only the GPU tests and not all the tests with GPU tests enabled.
I see this flaky test:datashader/tests/test_quadmesh.py::test_raster_quadmesh_autorange_reversed[dask.array]Not flaky at all:
pytest 'datashader/tests/test_quadmesh.py::test_raster_quadmesh_autorange_reversed[dask.array]'as this also fails. It is test pollution from the other array...Want to merge it after my other prs.