Vendor datashape #1284
Merged
Vendor datashape #1284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1284 +/- ##
==========================================
+ Coverage 83.52% 85.74% +2.21%
==========================================
Files 35 52 +17
Lines 9145 10870 +1725
==========================================
+ Hits 7638 9320 +1682
- Misses 1507 1550 +43
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Passes CI and successfully builds packages and docs. |
bmwiedemann
pushed a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Feb 14, 2024
https://build.opensuse.org/request/show/1146265 by user bnavigator + anag+factory is now included and maintained within datashader: * gh#holoviz/datashader#1003 * gh#holoviz/datashader#1284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1003.
Datashape does not import on Python 3.12. The project is unmaintained, there hasn't been a release on PyPI since 2016 and the latest git commit was 4 years ago. This PR vendors the source code within Datashader and removes the install dependency.
The Datashape test suite is also included and will be automatically run in CI. It takes less than 3 seconds to run on my dev machine so it will not noticeably affect CI run times.