Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest holoviz_tasks #1281

Merged
merged 1 commit into from
Sep 26, 2023
Merged

Update to latest holoviz_tasks #1281

merged 1 commit into from
Sep 26, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Sep 26, 2023

The changes in the install task are caching when a test fails. Beforehand, it will only do so if the test passed.

The other change is saving the environment files from the different runs, making debugging easier.

You can get the environment files here: https://github.com/holoviz/datashader/actions/runs/6309708107?pr=1281 under artifacts.

@codecov
Copy link

codecov bot commented Sep 26, 2023

Codecov Report

Merging #1281 (38a85c2) into main (3dab9df) will decrease coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1281      +/-   ##
==========================================
- Coverage   83.54%   83.52%   -0.03%     
==========================================
  Files          35       35              
  Lines        9134     9145      +11     
==========================================
+ Hits         7631     7638       +7     
- Misses       1503     1507       +4     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro requested a review from ianthomas23 September 26, 2023 11:10
Copy link
Member

@ianthomas23 ianthomas23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks really useful.

@ianthomas23 ianthomas23 merged commit f79f47a into main Sep 26, 2023
@ianthomas23 ianthomas23 deleted the small_maintenance branch September 26, 2023 11:36
@ianthomas23 ianthomas23 added this to the v0.15.3 milestone Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants