Support summary containing by reduction with other reductions #1257
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1256.
Adds support for the following combinations of
summary
andby
reductions:summary(by("cat1"), other_reduction)
and with the order swapped.summary(by("cat1"), by("cat1"))
summary(by("cat1"), by("cat2"))
The biggest change here is in the handling of categorical columns in
compiler.py
make_append()
. Previously thecategorical
flag was constant for all reductions within asummary
, now it is checked for each constituent reduction. Where categorical columns are reused, they are only extracted once.Also, the addition of
kwargs
toxr.DataArray
inby.finalize
has been modified to follow the same approach as inwhere
reductions, which is to add the new categorical coords/dims to a copy of thekwargs
, not modify them in-place. Hence each constituent reduction of asummary
can have different categorical coordinates from others.Tested on CPU and GPU, with and without Dask.