Use enum for row index column rather than None #1234
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Internally within Datashader we pass around column string names to identify which columns of the source (e.g. DataFrame) need to be passed to the low-level numba functions. Up until now we have used
None
to represent either no column, which would apply to anany()
reduction, or a virtual row index column for reductions likewhere
. The multiple use ofNone
for both is confusing, so this PR introduces a newEnum
forRowIndex
so that it is easy to identify this being different fromNone
representing no column required.External API is not changed.