Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make datashader.composite imports lazy #1222

Merged
merged 1 commit into from
May 26, 2023
Merged

Make datashader.composite imports lazy #1222

merged 1 commit into from
May 26, 2023

Conversation

ianthomas23
Copy link
Member

This PR moves the import of various datashader.composite functions into the functions that use them rather than at the top of the transfer_functions module. It makes the initial import of datashader much faster.

Thanks to @hoxbro for identifying this downstream.

Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool!

@codecov
Copy link

codecov bot commented May 26, 2023

Codecov Report

Merging #1222 (9a4b61d) into main (25fbc3c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main    #1222   +/-   ##
=======================================
  Coverage   83.61%   83.62%           
=======================================
  Files          35       35           
  Lines        8734     8738    +4     
=======================================
+ Hits         7303     7307    +4     
  Misses       1431     1431           
Impacted Files Coverage Δ
datashader/transfer_functions/__init__.py 87.13% <100.00%> (+0.09%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@ianthomas23 ianthomas23 merged commit c40e976 into holoviz:main May 26, 2023
@ianthomas23 ianthomas23 deleted the lazy_import_composite branch May 26, 2023 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants