Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new boolean
cuda
argument to theReduction._build_combine
function. This function (overridden in derived classes) returns a function that is used to combine the aggregations of multipledask
partitions.There is no change in functionality here, just a simplification of
where._build_combine
which is currently the only code that has differentcombine
behaviour depending of whether the calculations are occurring on the CPU or GPU. But the change is required for the upcoming CUDA mutex PRs which behave differently depending on the newcuda
argument.