Reduction append functions return index not boolean #1180
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Recently the various
Reduction._append
functions were changed to return a boolean to indicate if they have performed any modification to theiragg
. This was to support the newwhere
reductions that need to know if theirselector
reduction has modified anything so that they can propagate this to their ownagg
containing e.g. row index. Boolean was fine for that, but with the plan to introduce new 3D aggs such asmax_n
then a boolean is not sufficient as it needs to be the index of change in the final dimension.This PR just changes the return from a boolean to an integer index, to confirm that it does not break anything in CI.
True
is changed to0
, meaning index of0
in the 3rd agg dimension, andFalse
to-1
meaning no change has occurred.