New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include more test cases for record_duration #272

Merged

skjerns merged 1 commit into master from recorddruation_addon

Jan 23, 2025

Collaborator

skjerns commented Jan 23, 2025 •

edited

Loading

Based on #238 and #242 I assessed the recent changes in #268 and improved the changes

added more test cases for different manual record_durations
due to the conversion to long long we are limited to record durations between 0.001 and 60, which should be fine for most cases
checking for str(float) can lead to output of scientific notation, so force floating point notation with f{x:f}
To check for valid writing of record_duration, read the raw header instead of EdfWriter, as a safety check.

fixes #238


          include more test cases for record_duration

3b0490e

skjerns merged commit ccd9dc1 into master

32 of 33 checks passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet