Fix CodeQL warnings

Signed-off-by: Holger Friedrich <mail@holger-friedrich.de>
holgerfriedrich · Aug 9, 2024 · e0a95e0 · e0a95e0
1 parent 61bdb1d
commit e0a95e0
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/Audio.java b/bundles/org.openhab.core.model.script/src/org/openhab/core/model/script/actions/Audio.java
@@ -139,7 +139,7 @@ public static void increaseMasterVolume(@ParamDoc(name = "percent") final float
         if (newVolume - volume < .01) {
             // the getMasterVolume() may only returns integers, so we have to make sure that we
             // increase the volume level at least by 1%.
-            newVolume += .01;
+            newVolume += .01f;
         }
         if (newVolume > 1) {
             newVolume = 1;

diff --git a/bundles/org.openhab.core.test/src/main/java/org/openhab/core/test/java/JavaTest.java b/bundles/org.openhab.core.test/src/main/java/org/openhab/core/test/java/JavaTest.java
@@ -145,7 +145,7 @@ protected boolean waitFor(BooleanSupplier condition) {
      * @return true on success, false on timeout
      */
     protected boolean waitFor(BooleanSupplier condition, long timeout, long sleepTime) {
-        int waitingTime = 0;
+        long waitingTime = 0;
         boolean rv;
         while (!(rv = condition.getAsBoolean()) && waitingTime < timeout) {
             waitingTime += sleepTime;

diff --git a/bundles/org.openhab.core/src/test/java/org/openhab/core/JavaTest.java b/bundles/org.openhab.core/src/test/java/org/openhab/core/JavaTest.java
@@ -52,7 +52,7 @@ protected boolean waitFor(BooleanSupplier condition) {
      * @return true on success, false on timeout
      */
     protected boolean waitFor(BooleanSupplier condition, long timeout, long sleepTime) {
-        int waitingTime = 0;
+        long waitingTime = 0;
         boolean rv;
         while (!(rv = condition.getAsBoolean()) && waitingTime < timeout) {
             waitingTime += sleepTime;