Clean up install vs. build requirements #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Exclude `wheel` and `setuptools` from package dependencies - Exclude `packaging` from build dependencies; however, retain it as a package dependency since it is a valid runtime dependency
|
@hobu let me know if you have any issues with this, but if not, it would be seriously awesome to get this merged and pushed as a newer release on PyPI so we can update our downstream references and shake |
|
You might win the open source hero award for fastest maintainer @hobu... Much love from the PNW, my friend! I'm working on fixing our dependencies and this one was throwing us for a loop so I wanted to contribute the fix for all to enjoy. I'll keep an eye out for the PyPI version bump once you get a chance to release! |
hobu
added a commit
that referenced
this pull request
Aug 10, 2021
|
github actions borked right now, but when it catches up to the queue, the release will be pushed to PyPI. |
|
Thanks @hobu, it's really appreciated! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Clean up install vs. build requirements
wheelandsetuptoolsfrom package dependenciespackagingfrom build dependencies; however, retain it as a packagedependency since it is a valid runtime dependency
Issue
When downstream packages depend on
mgrstoday, they havewheelforced into their dependency graphs at install time. This occurs becausemgrsas the upstream package currently lists two of its build requirements--wheelandsetuptools--as install requirements. To clean this up, we can keepwheelandsetuptoolsas valid build system requirements inpyproject.toml, but we should omit them fromsetup.py'sinstall_requiressection.