Fixing Docker Dev Environment #456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MohamedBassem
requested changes
Oct 5, 2024
docker/Dockerfile.dev
Outdated
|
|
||
| RUN apk add --no-cache libc6-compat make g++ py3-pip linux-headers | ||
| ENV PUPPETEER_SKIP_DOWNLOAD true | ||
| FROM node:21-alpine AS base |
There was a problem hiding this comment.
The "as base" here is not needed.
Comment on lines
-11
to
-13
| environment: | ||
| MEILI_ADDR: http://meilisearch:7700 | ||
| DATA_DIR: /data |
There was a problem hiding this comment.
I think those are still needed (similar to those of the workers)
| MEILI_ADDR: http://meilisearch:7700 | ||
| DATA_DIR: /data | ||
| env_file: | ||
| - .env # Automatically load all variables from this file |
There was a problem hiding this comment.
If you want to add a .env, let's add a .env.sample (even if it's empty) in the directory so that people can get it up and running quickly.
2f62d53 to
82f9aaf
Compare
82f9aaf to
d490786
Compare
|
Removed the BASE and introduced an .env.sample for configuration recommendation |
|
Thanks @CrypticC3s4r! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I had issues running the Docker development environment without first setting up a local development environment.
And put the Environment variables into a seperate .env file