Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(web): Improve SidebarItem tap target accessibility #409

Merged

Conversation

Trugamr
Copy link
Contributor

@Trugamr Trugamr commented Sep 23, 2024

This PR enhances the accessibility and user experience of the SidebarItem component by expanding the clickable area to cover the entire item.

Before

chrome_Jgp0L9nYyq

After

chrome_JsRJSZFLMs

@MohamedBassem
Copy link
Collaborator

Ah that's a good catch, thanks @Trugamr! I'll review this over the weekend :)

@MohamedBassem MohamedBassem merged commit 8fe1927 into hoarder-app:main Sep 29, 2024
3 checks passed
@MohamedBassem
Copy link
Collaborator

Thanks a lot @Trugamr for the fix, and welcome to the contributors list!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants