[UI/Refactor] Admin Settings #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1,266 +1,11 @@ | |||
| "use client"; | |||
There was a problem hiding this comment.
This can be a server component now and replace useSession with getServerAuthSession
There was a problem hiding this comment.
This is throwing error, as we are using useClientConfig in serverStats component, which can not be used if the parent is not client side.
There was a problem hiding this comment.
you can access it by importing it directly from shared/config.ts
kamtschatka
reviewed
Jun 27, 2024
| const latestRelease = useLatestRelease(); | ||
|
|
||
| let newRelease; | ||
| if (latestRelease && currentRelease != latestRelease) { |
There was a problem hiding this comment.
potentially an issue for you to fix: #201
if the latest docker container is used, the UI still shows that there is a newer version available.
kamtschatka
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Desktop
Mobile