Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Clicking preview for image assets brings up the details modal #147

Merged
merged 1 commit into from
May 10, 2024

Conversation

lilacpixel
Copy link
Contributor

Hi there! Very simple tweak to make my and my spouse's lives a bit easier--as designers, we make heavy use of the ability to save images in Hoarder!

By default, link bookmarks have a clickable preview image and title, and the maximize button in the action bar opens a modal with the local text-only archive. Uploaded images don't have an external link, so clicking the preview image or title does nothing, and only clicking the maximize button opens the details modal so the full image can be viewed.

This change just makes preview images for image assets open the details modal--the same behavior as the maximize button. Makes them a little easier to hit on mobile 😸

It's my first time working with NextJS, so I hope everything looks okay. Thanks for making Hoarder; we're really enjoying it so far!

Copy link

vercel bot commented May 10, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
hoarder-app-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 6:19pm
hoarder-app-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 10, 2024 6:19pm

Copy link
Collaborator

@MohamedBassem MohamedBassem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes a lot of sense! Thanks a lot for taking the time to submit the PR!

Designers using Hoarder is an interesting usecase that I didn't consider before :) let me know if there's anything that would make your workflow better!

@MohamedBassem MohamedBassem merged commit cbc8dde into hoarder-app:main May 10, 2024
6 checks passed
@lilacpixel lilacpixel deleted the image-click-zoom branch May 11, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants