Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Keyboard Shortcut & Search Improvements #449

Closed
lucius346346 opened this issue Oct 2, 2024 · 6 comments
Closed

[Feature Request] Keyboard Shortcut & Search Improvements #449

lucius346346 opened this issue Oct 2, 2024 · 6 comments
Labels
feature request New feature or request

Comments

@lucius346346
Copy link

I would like to suggest a few enhancements to improve the usability of the search functionality:

Keyboard Shortcut for Search Bar:
A dedicated keyboard shortcut to focus the search bar (e.g., pressing / or Ctrl + F) would make it easier to quickly start searching.

Search as You Type:
It would be even better if typing the first letter of a search prompt automatically focuses on the search bar and begins searching without the need for manual focusing.

Escape Key to Clear Search:
When the search bar is focused and contains text, pressing the Esc key should clear the search entry instead of just losing focus. This would improve the UX by allowing users to quickly reset the search.

@kamtschatka kamtschatka added the feature request New feature or request label Oct 2, 2024
@kamtschatka
Copy link
Contributor

My take on this:

Searching

  • Searching with "/": really uncomfortable if you are not using a certain keyboard layout (for english layout it works great, german layout, which I am using, requires "SHIFT+7"). The github search does not work for me with shortcuts for that reason (it also works with "/")
  • Searching with CTRL+F: this is overriding the default browser behavior and REALLY annoying to me, as you can no longer search inside the page.
  • Docusaurus has the shortcut set to CTRL+K, I think that might be an option that works for everyone.

Searching as you type
not a big fan, especially if there is a shortcut for it

Escape key to clear search
Sounds good to me

@lucius346346
Copy link
Author

I get that the shortcuts I suggested could be tricky, and I agree that Ctrl+K seems like a better, more universal option. As much as I love "search as you type," I can live without it if there's a good shortcut.

The Esc key not clearing the search was my main frustration, so I’m really happy you’re on board with fixing that!

@MyWay
Copy link

MyWay commented Oct 4, 2024

It would be cool if, like linkding, the browser extension could provide a custom search engine so that when you type in the address bar the key you set, eg. 'ho' or whatever, it will automatically go on Hoarder and search there for the specified keywords.

@lucius346346
Copy link
Author

It would be cool if, like linkding, the browser extension could provide a custom search engine so that when you type in the address bar the key you set, eg. 'ho' or whatever, it will automatically go on Hoarder and search there for the specified keywords.

Isn't this really easy to do in most browser? You can add custom engine by yourself.

@Inventhrice
Copy link
Contributor

+1, I missed this issue while making my own (#545)

As I mentioned in that, we could maybe provide it as a setting per user?

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Oct 16, 2024
…#449

added ctrl+k to focus the search bar
added escape to delete the input of the search bar
fixed behavior of ctrl+e on windows, which would otherwise focus the chrome searchbar
@kamtschatka
Copy link
Contributor

@Inventhrice : the keyboard shortcut on windows would actually be "CTRL+E" and not "windows + e", so there won't be an explorer window that opens. However, on Chrome this will also focus the searchbar currently.

I have created a PR to fix that and added CTRL+K and Escape handling to the searchbar

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Oct 16, 2024
…#449

added ctrl+k to focus the search bar
added escape to delete the input of the search bar
fixed behavior of ctrl+e on windows, which would otherwise focus the chrome searchbar
@github-project-automation github-project-automation bot moved this from In Progress to Done in Hoarder's Roadmap Oct 19, 2024
kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Nov 2, 2024
…rder-app#449 (hoarder-app#554)

added ctrl+k to focus the search bar
added escape to delete the input of the search bar
fixed behavior of ctrl+e on windows, which would otherwise focus the chrome searchbar
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request New feature or request
Projects
Status: Done
Development

No branches or pull requests

4 participants