Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

last version bookmarks import error #281

Closed
nsk opened this issue Jul 7, 2024 · 17 comments
Closed

last version bookmarks import error #281

nsk opened this issue Jul 7, 2024 · 17 comments

Comments

@nsk
Copy link

nsk commented Jul 7, 2024

hi ,
on the latest pull version, still impossible to import a list of favorites in drag and drop mode from chrome, it says that something is going wrong?

chrome_7uBi5VRQ5r

@kamtschatka
Copy link
Contributor

Please post the logs, the screenshot alone does not help.

@nsk
Copy link
Author

nsk commented Jul 7, 2024

@kamtschatka I have nothing in the logs

@kamtschatka
Copy link
Contributor

There is either something in the logs of the "web" container or in the devtools.
alternatively you can also provide the file you want to import (i am also in discord, if you do not want to share it publicly)

@carduswork
Copy link

carduswork commented Jul 8, 2024

@kamtschatka got the same error,here is the log in chrome and web container ,maybe helpful
image
image
image

@kamtschatka
Copy link
Contributor

I just tried it with my installation and everything works fine, so must have to do with your state/bookmark file.
What happens? Does it not import anything at all, or are some of them skipped?
Can you provide the bookmarks file?

@carduswork
Copy link

I exported my bookmark file from a platform like raindrop,it works fine after i changed my bookmark file to the file exported from my chrom,thanks!

I just tried it with my installation and everything works fine, so must have to do with your state/bookmark file. What happens? Does it not import anything at all, or are some of them skipped? Can you provide the bookmarks file?

@kamtschatka
Copy link
Contributor

from a platform like raindrop, or raindrop?
I would like to try that out when I am back home. There is a safeguard against importing completely random bookmark files, but maybe there is a slight difference between the browser exported format and whatever you tried.

@nsk
Copy link
Author

nsk commented Jul 8, 2024

hi I did the conversion to .txt via the CLI do you think it would be possible to directly import the all-linx.txt directly into the interface without going through the CLI, I tried the other way to do it too but it doesn't work

@kamtschatka
Copy link
Contributor

At some point you'll have to provide the file or some instructions for me to reproduce what you are doing, otherwise whis discussion will go nowhere

@nsk
Copy link
Author

nsk commented Jul 8, 2024

I have a raindrop account I'm trying this way I'll come back and tell you if it works later

@kamtschatka
Copy link
Contributor

seems like the file simply has too many URLs in there, causing the requests to get too big.
I would also recommend deleting the export.zip again

@nsk
Copy link
Author

nsk commented Jul 8, 2024

how many links max in the file?? do you think ? thx

kamtschatka added a commit to kamtschatka/hoarder-app that referenced this issue Jul 9, 2024
limiting the length of the URL for batched requests to prevent 431 errors
@kamtschatka
Copy link
Contributor

The maximum length the URL can get is 15000 characters, after that this error happens.
each bookmark adds 26 characters to the URL length + whatever you use to access your installation. This leads to a maximum of around 600 for my installation.
Go for roughly 500 and you should be fine.

I have also opened a PR to limit the length automatically

@Snuupy
Copy link

Snuupy commented Nov 9, 2024

I was only able to batch add ~150 urls on my instance

I had ~350 to add so I had to split up adding them

can we increase the character length on the web form?

the error was also not very helpful "Failed to fetch"

@MohamedBassem
Copy link
Collaborator

@Snuupy How did you get your list of links? There's a better importing UI now in the settings than just adding them to the editor box.

@Snuupy
Copy link

Snuupy commented Nov 9, 2024

@MohamedBassem I had ~500 open tabs in Firefox and used https://addons.mozilla.org/en-US/firefox/addon/export-tabs-urls-and-titles/ to add each window (subject) to each collection. One of my windows had 350 tabs open. It was not an import of any other tools or files (although I have another 4k+ in raindrop I have yet to import)

@MohamedBassem
Copy link
Collaborator

@Snuupy As you figured out, importing 350 links from the editor box doesn't give you the best experience. You might be better off using the CLI for such list instead (https://docs.hoarder.app/import#import-using-the-cli), if you're comfortable with using CLIs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants