Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DFPL-2326 c110a Design Changes to Applicant's details (LA) #5812

Open
wants to merge 42 commits into
base: master
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
42 commits
Select commit Hold shift + click to select a range
ca88f77
update ccd def
chak-shing-lo-justice Jan 10, 2025
665f84a
Revert java code changes
chak-shing-lo-justice Jan 10, 2025
980f07a
revert SDO.json
chak-shing-lo-justice Jan 10, 2025
febd375
update ccd definition
chak-shing-lo-justice Jan 13, 2025
cd83b7f
update controller and service
chak-shing-lo-justice Jan 15, 2025
53b977e
remove deprecated and fix historical compatibility
chak-shing-lo-justice Jan 15, 2025
bf62edb
Merge branch 'master' into DFPL-2326
chak-shing-lo-justice Jan 15, 2025
491aea0
remove deprecated event
chak-shing-lo-justice Jan 15, 2025
5bd3050
remove deprecated feature flag
chak-shing-lo-justice Jan 16, 2025
51c6d1a
fix serialisation issue
chak-shing-lo-justice Jan 16, 2025
86c69d9
update unit test
chak-shing-lo-justice Jan 16, 2025
37e42e5
fix unit test
chak-shing-lo-justice Jan 17, 2025
e9b465e
fix unit test
chak-shing-lo-justice Jan 17, 2025
ae2716e
deprecate old event and field
chak-shing-lo-justice Jan 17, 2025
40a7ca1
Update LocalAuthority.java
chak-shing-lo-justice Jan 17, 2025
9af2273
Update case.json
chak-shing-lo-justice Jan 17, 2025
a234a09
fix isLocalAuthority checking
chak-shing-lo-justice Jan 17, 2025
f90d20a
fix when main contact is empty
chak-shing-lo-justice Jan 17, 2025
21c21b2
Update TaskListServiceTest.java
chak-shing-lo-justice Jan 17, 2025
a8dd053
deprecate mainContactLabel
chak-shing-lo-justice Jan 17, 2025
0c4400b
Update CaseSubmissionCheckerTest.java
chak-shing-lo-justice Jan 17, 2025
a743da5
Merge branch 'master' into DFPL-2326
chak-shing-lo-justice Jan 20, 2025
9b3b7c2
Update case.json
chak-shing-lo-justice Jan 20, 2025
42feb51
Merge branch 'DFPL-2326' of https://github.com/hmcts/fpl-ccd-configur…
chak-shing-lo-justice Jan 20, 2025
4966c53
Update SubmitCaseApiTest.java
chak-shing-lo-justice Jan 20, 2025
21bbfb2
Merge branch 'master' into DFPL-2326
AlistairEdwinOsborne Jan 22, 2025
08892e0
fix SubmitCaseApiTest
chak-shing-lo-justice Jan 22, 2025
125f3aa
fix SubmitCaseApiTest
chak-shing-lo-justice Jan 22, 2025
02190e6
fix SubmitCaseApiTest
chak-shing-lo-justice Jan 22, 2025
571852a
fix ccd def
chak-shing-lo-justice Jan 27, 2025
8a0162a
update name
chak-shing-lo-justice Jan 29, 2025
1a21a0b
Merge branch 'master' into DFPL-2326
chak-shing-lo-justice Jan 29, 2025
6a5690d
fix test
chak-shing-lo-justice Jan 29, 2025
6229ff0
fix unit test
chak-shing-lo-justice Jan 29, 2025
7fc023d
Update CaseSummaryControllerSubmittedTest.java
chak-shing-lo-justice Jan 29, 2025
009aebc
fix unit test
chak-shing-lo-justice Jan 29, 2025
fb5af82
Update case.json
chak-shing-lo-justice Jan 29, 2025
b9b2074
Update Colleague.java
chak-shing-lo-justice Jan 29, 2025
76f10c3
Update case.json
chak-shing-lo-justice Jan 29, 2025
5707a13
Merge branch 'master' into DFPL-2326
chak-shing-lo-justice Jan 30, 2025
3b8f5bb
Update application-draft.txt
chak-shing-lo-justice Jan 30, 2025
3233f43
Update application.txt
chak-shing-lo-justice Jan 30, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update CaseSubmissionCheckerTest.java
  • Loading branch information
chak-shing-lo-justice committed Jan 17, 2025
commit 0c4400b9011e0d1abde828f05da9538084dae3dc
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,6 @@
import static uk.gov.hmcts.reform.fpl.enums.Event.ORDERS_SOUGHT;
import static uk.gov.hmcts.reform.fpl.enums.Event.RESPONDENTS;
import static uk.gov.hmcts.reform.fpl.enums.Event.SELECT_COURT;
import static uk.gov.hmcts.reform.fpl.enums.YesNo.NO;
import static uk.gov.hmcts.reform.fpl.enums.YesNo.YES;

@ExtendWith(SpringExtension.class)
Expand Down Expand Up @@ -314,7 +313,7 @@ void shouldExcludeGroundForApplicationWhenDischargeOfCareApplication() {

@Test
void shouldValidateApplicantLAIfLocalAuthorityIsYes() {
when(caseData.getIsLocalAuthority()).thenReturn(YES);
when(caseData.checkIfCaseIsSubmittedByLA()).thenReturn(true);

when(eventsChecker.validate(any(), any())).thenReturn(List.of("Error not included"));
when(eventsChecker.validate(CASE_NAME, caseData)).thenReturn(caseNameErrors);
Expand Down Expand Up @@ -358,7 +357,7 @@ void shouldValidateApplicantLAIfLocalAuthorityIsYes() {

@Test
void shouldValidateApplicantSolIfLocalAuthorityIsNo() {
when(caseData.getIsLocalAuthority()).thenReturn(NO);
when(caseData.checkIfCaseIsSubmittedByLA()).thenReturn(false);

when(eventsChecker.validate(any(), any())).thenReturn(List.of("Error not included"));
when(eventsChecker.validate(CASE_NAME, caseData)).thenReturn(caseNameErrors);
Expand Down Expand Up @@ -460,7 +459,7 @@ class GroupedValidation {

@Test
void shouldValidateApplicantLAIfLocalAuthorityIsYes() {
when(caseData.getIsLocalAuthority()).thenReturn(YES);
when(caseData.checkIfCaseIsSubmittedByLA()).thenReturn(true);

when(eventsChecker.validate(any(), any())).thenReturn(List.of("Error not included"));
when(eventsChecker.validate(CASE_NAME, caseData)).thenReturn(caseNameErrors);
Expand Down Expand Up @@ -493,7 +492,7 @@ void shouldValidateApplicantLAIfLocalAuthorityIsYes() {

@Test
void shouldValidateApplicantLAIfLocalAuthorityIsNo() {
when(caseData.getIsLocalAuthority()).thenReturn(NO);
when(caseData.checkIfCaseIsSubmittedByLA()).thenReturn(false);

when(eventsChecker.validate(any(), any())).thenReturn(List.of("Error not included"));
when(eventsChecker.validate(CASE_NAME, caseData)).thenReturn(caseNameErrors);
Expand Down
Loading