Fix generate_base_runnable in setup.py to make a custom input interface available for each player #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ace available for each player
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request fixes the generate_base_runnable function in setup.py to ensure that a custom input interface is available for each player. Previously, the function did not properly handle the case when the input_func parameter was not None and the model parameter was None. This caused an error to be raised. With this fix, the function now correctly generates a BaseChatModel instance or a Runnable instance based on the provided parameters. Additionally, a warning message is logged if an invalid pair of model and input_func is provided, and the function falls back to using a chat model with the DEFAULT_MODEL.