MDC: Replace internal implementation #83
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TreeMap seems to be relatively lighter than HashMap (very minimally) and performance is similar. The reason for dropping the old implementation is to reduce complexity, so instead of a complex in-house implementation we opt for a simpler layer that outsources to the TreeMap. Future iterations can be made by playing around with the `StringMap` interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces ring-buffer based object pool with a simple TreeMap-based implementation.
This trades off a little bit of memory and performance (maybe) for a much better and simpler to reason
about codebase.
If there's a better map implementation, we can use it through the new StringMap interface.
As a side effect, this ensures the ContextMap behaviour is sane now
fix #82